Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated Git tag handling to be more robust #1399

Merged
merged 134 commits into from
Mar 25, 2024

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Made sure pipeline fails if git tag is not correcly published
  • Added post-publishing test that fails if the git tag is not found
  • Tested fail state locally as having a git tag rejected isn't exactly easy to provoke

Pipeline Reference

Pipeline
working run

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Mar 23, 2024
@AlexanderSehr AlexanderSehr self-assigned this Mar 23, 2024
@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue and removed Needs: Triage 🔍 Maintainers need to triage still labels Mar 23, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review March 23, 2024 11:20
@AlexanderSehr AlexanderSehr requested review from a team as code owners March 23, 2024 11:20
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) March 23, 2024 11:20
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 4c54f94 into Azure:main Mar 25, 2024
13 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/tagTest branch March 25, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants